-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4439: Denote which theme has been set as the admin theme #3166
base: 1.x
Are you sure you want to change the base?
Conversation
Related to: backdrop/backdrop-issues#4439 |
Website: http://3166.backdrop.backdrop.qa.backdropcms.org |
$theme->is_default = ($theme->name == $theme_default); | ||
$theme->is_admin = ($theme->name == $admin_theme); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way this is implemented these properties are available only within the context of the themes listing page. I would like us to move these into system_rebuild_theme_data()
and/or list_themes()
, so that they become available info on themes in general. Would this be an API change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving it into list_themes()
would be appropriate. It would be an API expansion to do so, since these properties would be made available in more places than they had been previously. That's fine to do in our 1.x release. In our docblock for list_themes()
we'd just have to include documentation on the new properties and include @since
sections for the new properties.
Then instead of this function (system_themes_page()
) calling $themes = system_rebuild_theme_data();
, it should pull from list_themes()
instead so it doesn't have to duplicate the work.
…oard focus Fixes backdrop/backdrop-issues#3166 Credits to @antijingoist
Issue backdrop#3166: Remove views-specific code from autosubmit fixes.
Fixes backdrop/backdrop-issues#4439